fix(cairo_native): use current dir in cairo compile #2815
Conversation
|
This change is |
noaov1
force-pushed
the
noa/use_cairo_native_dir
branch
from
a824d83 to
3be2b64
Compare
noaov1
changed the title
noaov1
force-pushed
the
noa/use_cairo_native_dir
branch
from
3be2b64 to
b34c5ab
Compare
noaov1
force-pushed
the
noa/use_cairo_native_dir
branch
from
b34c5ab to
c487834
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1)
crates/blockifier/build.rs line 9 at r1 (raw file):
let cairo_native_dir = current_dir().expect("Failed to get current directory").join(PathBuf::from("cairo_native"));
this is resolved at runtime, and the resulting dir depends on the calling context; this is desired behavior?
Code quote:
current_dir().expect("Failed to get current directory")
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware)
crates/blockifier/build.rs line 9 at r1 (raw file):
Previously, dorimedini-starkware wrote…
this is resolved at runtime, and the resulting dir depends on the calling context; this is desired behavior?
@avi-starkware ?
I just reverted the changes in #2289.
Do you have other ideas?
|
Previously, noaov1 (Noa Oved) wrote…
Why do you want to do this? The problem with using and running would give you different results. Which is weird and unexpected behavior that could easily cause bugs in the future. Why are you doing this PR? |
No description provided.